[NewIR]Add cinn RuntimeDialect and JitKernelOp #56074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
winter-wang
reviewed
Aug 8, 2023
winter-wang
reviewed
Aug 8, 2023
winter-wang
reviewed
Aug 8, 2023
| }; | ||
|
|
||
| ::ir::Operation* cinn_op = | ||
| ::ir::Operation::Create({}, op_attrs, {}, op_info); |
There was a problem hiding this comment.
建议可以考虑通过builder来构建op。那个更方便一点。
There was a problem hiding this comment.
Goog advice，我来优化下，可能会放到下个PR
zhangbo9674
reviewed
Aug 8, 2023
zhangbo9674
approved these changes
Aug 8, 2023
This was referenced Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
Pcard-67164
NOTE: THIS IS NOT FINAL STATE!
JitKernel is unified runtime operation to represent jit compiled function ptr from backend, such as nvrct.
Ideally, JitKernel should only contains ArrayAttribute with each element is PointerAttribute, which is jit function ptr indeed.
Currently, we regard hlir::framework::Instruction temporarily, and will spilt executor information like scope, inputs, outputs into InterpretorCore module in next big PR.