[PIR]Add cinn::dialect::GroupOp for BuildCinnPass #57304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
commented
Sep 19, 2023
| // TODO(Aurelius84): Need to figure out what we need indeed for GroupOp. | ||
| // Currently we paste almost members here and will remove them step by | ||
| // step. | ||
| struct GroupInfo { |
There was a problem hiding this comment.
GroupInfo 目前在Compiler阶段以及Fusion Merge都会用到，目前是作为了一个Attribute把那定到Group里，方便存取。后续将考虑看是否可以解耦，以独立于pir::Op体系
Aurelius84
commented
Sep 19, 2023
|
|
||
| // TODO(Aurlius84): Need to figure out how to rebuild relation info of ops outer | ||
| // GroupOp | ||
| void GroupOp::Build(pir::Builder &builder, |
There was a problem hiding this comment.
GroupOp的构建和内在Ops的「断边」以及「重建」将在另一个PR里的BuildCinnPass::ReplaceWithGroupOp 里实现
Aurelius84
changed the title
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
* [PIR]Add cinn::dialect::GroupOp * fix unittest * fix typo
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* [PIR]Add cinn::dialect::GroupOp * fix unittest * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Description
Pcard-67164
see: #56880
整体适配思路详见技术文档：#56879