【Hackathon 7th PPSCI No.13】 Backward decomp for put_along_axis_grad op #67891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Comment on lines
2447
to
2449
| // 如果没有特殊说明，要替换的位置全部指在x这个tensor上的对应位置 | ||
| // 对应位置的计算见文件paddle\phi\kernels\funcs\gather_scatter_functor.cc的L293-L319 | ||
| // 将要替换的位置全部赋值为0 |
There was a problem hiding this comment.
代码注释可以简化一下，并且用英文比较好
There was a problem hiding this comment.
这是参考Phi的kernel实现的版本，这个注释是方便老师阅读，后续合入前会删除的，老师看看是否有什么问题。
There was a problem hiding this comment.
这是参考Phi的kernel实现的版本，这个注释是方便老师阅读，后续合入前会删除的，老师看看是否有什么问题。
感觉没其他问题
|
PR-CI-Inference 需要麻烦老师帮忙重跑一下，我这没有权限重跑_(:з」∠)_ |
luotao1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator Mechanism
PR Types
New features
Description
反向拆解put_along_axis_grad op