Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Fluid code to Google C++ style #9685

Merged
merged 1 commit into from
Apr 6, 2018
Merged

Unify Fluid code to Google C++ style #9685

merged 1 commit into from
Apr 6, 2018

Conversation

wangkuiyi
Copy link
Collaborator

@wangkuiyi wangkuiyi commented Apr 6, 2018 •
edited
Loading

Fix #9683

@wangkuiyi
Copy link
Collaborator Author

wangkuiyi commented Apr 6, 2018 •
edited
Loading

This PR contains only one Git commit. When I create it, I had to add the --no-verify flag:

git commit -a -m 'Unify Fluid code to Google C++ style'  --no-verify

otherwise there would be many cpplint errors.

I will file a separate PR to fix cpplint errors.

@wangkuiyi wangkuiyi requested review from Xreki, kexinzhao and reyoung April 6, 2018 18:21
@wangkuiyi wangkuiyi mentioned this pull request Apr 6, 2018
Closed
@wangkuiyi wangkuiyi merged commit 797a718 into PaddlePaddle:develop Apr 6, 2018
@wangkuiyi wangkuiyi deleted the fluid-code-style branch April 7, 2018 15:54
@wangkuiyi wangkuiyi mentioned this pull request Apr 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daming-lu daming-lu daming-lu approved these changes

@Xreki Xreki Awaiting requested review from Xreki

@kexinzhao kexinzhao Awaiting requested review from kexinzhao

@reyoung reyoung Awaiting requested review from reyoung

Assignees
No one assigned
Labels
Code Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangkuiyi @daming-lu