【Hackathon 7th PPSCI No.4】NO.4 DrivAerNet 论文复现 #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
开发者你好，感谢你的参与！由于你的黑客松赛题完成度较高，其PR已被锁定，请尽快完善锁定的PR，并确保在2025年1月3日前完成合入。逾期未合入PR将无法获得奖金发放。 |
|
📢：请尽快完善锁定的PR，并确保在2025年1月10日（不再延期）前完成合入。逾期未合入PR将无法获得奖金发放。 |
ppsci/arch/regdgcnn.py
Outdated
Comment on lines
189
to
196
| """ | ||
| Initializes the RegDGCNN model with specified configurations. | ||
|
|
||
| Args: | ||
| args (dict): Configuration parameters including 'k' for the number of neighbors, 'emb_dims' for embedding | ||
| dimensions, and 'dropout' rate. | ||
| output_channels (int): Number of output channels (e.g., for drag prediction, this is 1). | ||
| """ |
There was a problem hiding this comment.
- docstring移动到类下方
- Args列表和代码对不上
| """ | ||
|
|
||
|
|
||
| from typing import Tuple |
There was a problem hiding this comment.
新增的.py文件开头建议都加上
from __future__ import annotations
docs/zh/examples/drivaernet.md
Outdated
| @@ -0,0 +1,496 @@ | |||
| # DrivAerNet: A Parametric Car Dataset for Data-Driven Aerodynamic Design and Graph-Based Drag Prediction(DrivAerNet：一个用于数据驱动空气动力学设计和基于图的阻力预测的参数化汽车数据集) | |||
There was a problem hiding this comment.
Suggested change
| # DrivAerNet: A Parametric Car Dataset for Data-Driven Aerodynamic Design and Graph-Based Drag Prediction(DrivAerNet：一个用于数据驱动空气动力学设计和基于图的阻力预测的参数化汽车数据集) | |
| # DrivAerNet | |
| DrivAerNet: A Parametric Car Dataset for Data-Driven Aerodynamic Design and Graph-Based Drag Prediction(DrivAerNet：一个用于数据驱动空气动力学设计和基于图的阻力预测的参数化汽车数据集) |
ppsci/solver/solver.py
Outdated
| @@ -166,7 +166,7 @@ def __init__( | |||
| # (Recommended)Params can be passed within cfg | |||
| # rather than passed to 'Solver.__init__' one-by-one. | |||
| self._parse_params_from_cfg(cfg) | |||
|
|
|||
| self.cur_metric = 0 | |||
There was a problem hiding this comment.
- 移动到
self.best_metric = {上方 - 初始值改为float("inf")
There was a problem hiding this comment.
solver.train里的cur_metric初始化这行删掉，并且把cur_metric改为self.cur_metric
There was a problem hiding this comment.
@LilaKen 需要把solver::train函数里的所有cur_metric，改为self.cur_metric
| @@ -804,6 +805,53 @@ def __call__(self): | |||
| return learning_rate | |||
|
|
|||
|
|
|||
| class ReduceOnPlateau(LRBase): | |||
|
@LilaKen 补充PR描述，概括该PR的内容 |
Co-authored-by: HydrogenSulfate <[email protected]>
Co-authored-by: HydrogenSulfate <[email protected]>
Co-authored-by: HydrogenSulfate <[email protected]>
Co-authored-by: HydrogenSulfate <[email protected]>
Co-authored-by: HydrogenSulfate <[email protected]>
Co-authored-by: HydrogenSulfate <[email protected]>
Co-authored-by: HydrogenSulfate <[email protected]>
|
hi, @LilaKen
|
This was referenced Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs、Docs
Describe
本PR的目标是复现RegDGCNN网络，将DrivAerNet处理成ppsci版API，并且加入对应的文档说明。
论文信息
复现结果