[PaddlePaddle Hackathon] Add test of paddle.nn.CosineSimilarity #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kolinwei
requested changes
Oct 9, 2021
kolinwei
requested changes
Oct 11, 2021
kolinwei
requested changes
Oct 11, 2021
|
@kolinwei 感谢建议，已更新v4，请审阅 |
可以再加一些异常的case，比如axis为-1，axis比输入的纬度大等。 |
obj.run的data能否输入多个参数呀 |
kolinwei
requested changes
Oct 13, 2021
| # cos_sim_func(x1_tensor, x2_tensor) | ||
| try: | ||
| cos_sim_func(x1_tensor, x2_tensor) | ||
| except ValueError: |
There was a problem hiding this comment.
异常捕获的地方需要在case里面验证抛出的异常类型和错误信息。
|
已更新 @kolinwei |
kolinwei
approved these changes
Oct 15, 2021
|
已更新 @DDDivano |
DDDivano
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
api.nn
Describe
Add test of paddle.nn.CosineSimilarity.