Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-coding styles to SVG nodes and edges so that exporting could work #380

Merged
merged 12 commits into from
Apr 10, 2018
Merged

Conversation

daming-lu
Copy link
Collaborator

@daming-lu daming-lu commented Apr 10, 2018

Note polyline (a line with one turn, like an 'L' or '7') will have shadows in the area:

screen shot 2018-04-09 at 9 40 13 pm

So we have to set it to empty now:

screen shot 2018-04-09 at 10 08 23 pm

This might be a bug in dagre-d3 or graphlib, which dagre-d3 is based on.

Also note the graph on the web page is not affected:

screen shot 2018-04-09 at 10 15 40 pm

Copy link
Collaborator

@jetfuel jetfuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daming-lu daming-lu merged commit 1ebd604 into PaddlePaddle:develop Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants