Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Hackathon No.71】为 PaddleScience 新增支持随机/Quasi采样法 #58
【Hackathon No.71】为 PaddleScience 新增支持随机/Quasi采样法 #58
Changes from 2 commits
c328ea6
39568bc
b2c1a9c
42174b3
df2b08a
bfbd871
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我们这里提到的准随机采样,是否也完全支持sampler中拉丁超立方、halton等序列?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
您好,scipy中也支持上述序列采样,具体参考scipy.stats.qmc,如下图是各种采样的对比
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,可以。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可否对边界随机采样的点定义不同标识的set集合(eg: inlet_bc, outlet_bc, side_bc, circle_bc……),并在定义BC时,可直接选择不同标识的点集定义。 目的是能够保证几何尺寸变化后,随机点、边界条件等同步发生变化,放弃if判断的方法。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这块可以考虑下是否有些好的想法哈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
除提及的增强采样外,能否支持如下图示(仅做局部增强效果参考)的局部增强随机采样?如2D圆柱绕流,圆周周边可以划定区域进行局部增强采。API参数中可以选择局部增强的方式,如中心方向区域、中心十字形区域类型,并能够分别定义局部增强的参数。
示例1:
示例2:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
您好,您说的效果可能需要73题目的支持(几何图形的布尔运算),但是最近我有点事情,回复会比较慢,但是我会继续完善该RFC,感谢您的REVIEW
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的了解,若有精力可以尝试下😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你好,我为73题目以及71题目写了一个简单的demo,可以在此处查看Geometry
但是现阶段非常粗糙,运行效果在repo目录下的ipynb文件可以查看,希望您能给给意见,或者可以联系我的邮箱[email protected]