Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update .gitignore to ignore output files #6231

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

RedContritio
Copy link
Contributor

@RedContritio RedContritio commented Oct 19, 2023

添加了 gitignore 项以忽略 docs 构建生成的大部分文件。

@sunzhongkai588

其余构建过程会对仓库会产生影响的项:

  • docs/api/paddle/*_cn.rstCOPY-FROM 块的更新
  • docs/practicesdocs/guides 中,ipynb 被移除,构建为新增的 mdpng

@paddle-bot
Copy link

paddle-bot bot commented Oct 19, 2023

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-6231.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:飞桨文档预览工具

api_info_all.json
api_info_dict.json
api_label
en_cn_files_diff
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 codestyle 能过么?看起来少了个换行,可以拉一下最新的 develop 看看这里能不能过

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

啊 看来是 #6239 还没合,该 PR 过完 CI 后马上合入,麻烦稍后合入后 merge 下 develop 并修复下 codestyle

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6239 已合入,麻烦 merge 下最新的 develop~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已更新

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emmm,force push 了把我之前修过的覆盖掉了

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

新的 pre-commit 项导致产生了 index.html 等输出

你是 run --all-files 了么?没有添加新的 pre-commit 项的,只有上古的一个 pre-commit convert-markdown-into-html,这个我不是很清楚现在还有没有用

Copy link
Contributor Author

@RedContritio RedContritio Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是,pre-commit run --all-files 了,产生了几个额外的 index.html 输出

Copy link
Contributor Author

@RedContritio RedContritio Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对比了一下 markdown 和 html,看起来确实是 convert-markdown-into-html 的作用,这部分(gitignore)需要移除掉吗

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先移除掉吧,因为我也不清楚这个 hook 现在是否还有用……如果只是历史遗留,以后可以考虑直接删掉这个 hook 及相关文件

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经取消掉最后一次 commit (再次 -f)

docs/api/.gitignore Outdated Show resolved Hide resolved
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants