Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example helm chart. #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nanliu
Copy link
Contributor

@nanliu nanliu commented May 31, 2017

No description provided.

@nanliu
Copy link
Contributor Author

nanliu commented May 31, 2017

Per last meeting, I cleaned up our internal charts, added all dns env vars, and provided it as an example to fix #16. I still need some testing to verify, but at least dry-run upgrades seems correct. The 0.4.0 image is not available because of #60, but we use a custom registry anyhow, so the values are overwritten in deployment.

@luna-duclos
Copy link

I have no experience with helm, could someone that has used helm review this ?

@nanliu
Copy link
Contributor Author

nanliu commented Jun 9, 2017

If we can resolve #60, I can submit this directly to the official k8s chart repo: https://github.com/kubernetes/charts. It will get a fine comb review, but that's not feasible until this is a deployable chart (and I rather avoid switching it to my own docker registry).

@gianrubio
Copy link
Contributor

@luna-duclos I can review this when #60 is solved, do you have a plan to push this tag?

@nanliu please add the rbac rules to this chart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants