Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNY-222 migrate from pip-env to requirements file #1

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

HilaryLynch-expanse
Copy link
Collaborator

@HilaryLynch-expanse HilaryLynch-expanse commented Aug 11, 2021

Description

https://qadium.atlassian.net/browse/GNY-222

Migrate the Xpanse Python SDK from using pipenv to a requirements file using the command in the ticket.
Will follow up with the dev packages in the github actions ticket

How Has This Been Tested?

Running the following steps locally:
PYTHONPATH=$PYTHONPATH$(pwd)
pip3 install -r requirements.txt
python3
[in shell] from expanse.client import ExClient
[in shell] types = client.issues.issue_types.list().dump()

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)

@HilaryLynch-expanse HilaryLynch-expanse requested a review from a team August 11, 2021 17:24
@andrew-paloalto
Copy link

I think you'll also want to run pipenv lock -r --dev so we have a requirements-dev.txt file for handling our dev dependencies.

@andrew-paloalto
Copy link

It also sounds like there's all kind of drama about how to generate a dev-only requirement list - pypa/pipenv#3316

@andrew-paloalto
Copy link

nvm, I see you already added in the other PR, approving..

@HilaryLynch-expanse
Copy link
Collaborator Author

Yeah, definitely some drama/opinions around the dev requirements. I'll rename the dev requirements file in the other pr to align with this format, though (I think I did dev-requirements.txt instead of requirements-dev.txt)

@HilaryLynch-expanse HilaryLynch-expanse merged commit 451b252 into main Aug 11, 2021
@HilaryLynch-expanse HilaryLynch-expanse deleted the GNY-222 branch August 11, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants