[FR] Sync Content-Type/Accept with Request/Response #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blindaa121
force-pushed
the
content-type-redux
branch
from
ec1a121 to
8cab975
Compare
|
Size Change: -72.3 kB (-2%) Total Size: 3.76 MB
ℹ️ View Unchanged
|
|
Visit the preview URL for this PR (updated for commit 33ff0a1): https://docusaurus-openapi-36b86--pr218-ttcj4gsa.web.app (expires Sun, 13 Nov 2022 16:45:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
Seems to work ok - have you encountered any issues? Screen.Recording.2022-10-05.at.2.46.42.PM.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces support for extending the current Redux Store from the
ApiItemcomponent level. This enables the ability to sync MIME/media type changes (viaMimeTabs) with theApiDemoPanel.Motivation and Context
See #197
How Has This Been Tested?
Tested with Petstore API
Content-Type/Request: Tested by toggling between
MimeTabsand ensuring that each selection synced and updated theContent-Typefield within theApiDemoPanelandCurlcomponents. Example can be tested hereAccept/Response: Tested by toggling between
MimeTabsand ensuring that each selection synced and updated theAcceptfield within theApiDemoPanelandCurlcomponents. Example can be tested hereScreenshots (if appropriate)
Content-Type/Request
Screen.Recording.2022-10-10.at.10.05.24.AM.mov
Accept/Response
Screen.Recording.2022-10-10.at.10.07.18.AM.mov
Types of changes
Checklist
TODO
Although the current implementation supports the syncing between
MimeTabsand theApiDemoPanel, there are still some things to note:ApiDemoPanelfields (Content-Type/Accept/Base URL) are not persisted throughout the user session.ApiDemoPanelfields (Content-Type/Accept) does not update theMimeTabselection.Further investigation is needed to fully support the use cases above.