-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] SchemaTabs arrows not rendering for response examples #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blindaa121
changed the title
[Bug] Use ResizeObserver to conditionally render SchemaTabs arrows
[Bug] SchemaTabs arrows not rendering for response examples
Nov 4, 2022
Size Change: +102 B (0%) Total Size: 4.01 MB
ℹ️ View Unchanged
|
Visit the preview URL for this PR (updated for commit 50129ac): https://docusaurus-openapi-36b86--pr322-dfayyvk2.web.app (expires Sun, 04 Dec 2022 02:14:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
sserrata
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consists of fixing
SchemaTabs
arrows not being rendered for Response examples. Currently, arrows are rendered whenSchemaTabs
are first mounted and satisfy the condition thattabOffsetWidth < tabScrollWidth
. The issue is that this condition only applies to the firstSchemaTabs
ref and does not carry on to subsequent tabs with their respectivetabOffsetWidth
andtabScrollWidth
values. To remedy this, the ResizeObserver API is used to accurately capture eachSchemaTabs
ref and their respectivetabOffsetWidth
andtabScrollWidth
values.How Has This Been Tested?
Tested with Prisma Access Configuration API:
Screenshots (if appropriate)
Before:
Screen.Recording.2022-11-03.at.9.37.47.PM.mov
After:
Desktop | macOS | Chrome
Screen.Recording.2022-11-03.at.7.04.36.PM.mov
Mobile | macOS | iOS Simulator
Types of changes
Checklist