Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: date-time examples should include time #427

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

IanVS
Copy link
Contributor

@IanVS IanVS commented Feb 13, 2023

Description

I noticed that examples for strings formatted as date-time did not include times, only the date. This change includes the time as well.

Motivation and Context

https://swagger.io/docs/specification/data-models/data-types/#string specifies that date-time should include the time.

How Has This Been Tested?

I haven't tested it, actually, but it's a simple change.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@welcome-to-palo-alto-networks

🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 0c276e1):

https://docusaurus-openapi-36b86--pr427-rpuia9ll.web.app

(expires Wed, 15 Mar 2023 16:46:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Member

@sserrata sserrata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

@jasikpark jasikpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sserrata sserrata merged commit ca21154 into PaloAltoNetworks:main Feb 14, 2023
@welcome-to-palo-alto-networks

🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️

@IanVS IanVS deleted the date-time branch February 14, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants