handle various additionalProperties cases #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 894b88b): https://docusaurus-openapi-36b86--pr803-n0xt1gn4.web.app (expires Wed, 05 Jun 2024 14:47:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
Hi @Ugzuzg, I'm in the process of reviewing this PR. So far, it looks good but I was wondering if you might have an OpenAPI spec/snippet that reproduces the issue you were seeing before the fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handle various schemas inside
additionalPropertiescorrectly (as far as I can tell).Motivation and Context
Trying to fix issues I have with properly displaying types in
additionalProperties.How Has This Been Tested?
In unit tests and documentation.
Screenshots (if appropriate)
Types of changes
Checklist