-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Improve category link support when grouping by tags #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +4.07 kB (0%) Total Size: 2.38 MB
ℹ️ View Unchanged
|
Visit the preview URL for this PR (updated for commit 1248b4e): https://docusaurus-openapi-36b86--pr97-k0uazgwm.web.app (expires Sun, 19 Jun 2022 21:28:59 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
blindaa121
approved these changes
May 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🚀
🤞🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seeks to improve category link support when using
sidebarOptions
to group paths by "tags".Lots of changes:
categoryLinkSource
tosidebarOptions
index.api.mdx
to<unique id>.intro.mdx
for distinctiongenerated-index
category links when grouping by tags (switches to doc link whenuseInfoAsCategoryLink
istrue
)generated-index
description (only whencategoryLinkSource
isundefined
)InfoObject
to includetags
(necessary for associating tags with tagged grouping of paths)Additional Changes:
font-size
for h2 tagsMotivation and Context
Previously, when grouping by "tags" intro docs were omitted since, when referencing multiple specs, the index MDX file was being overwritten.
How Has This Been Tested?
Tested locally using Petstore API and CSPM API.