Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Commit

Permalink
Benchmark termination fix - added missing break
Browse files Browse the repository at this point in the history
  • Loading branch information
PalNilsson committed Jan 10, 2019
1 parent 3dec733 commit 7e4b8f8
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
8 changes: 8 additions & 0 deletions CHANGES
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,14 @@ M movers/rucio_sitemover.py (8)

////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

73.11:

Benchmarking bug fix
- Added missing break after benchmark termination. Previously benchmark command could not be terminated if they ran
for longer than the allowed time (RunJob)

////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

TODO:

todo: remove the explicit usages of schedconfig.lfchost and replace with an experiment specific method (getFileCatalog())
Expand Down
2 changes: 1 addition & 1 deletion PILOTVERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
PICARD 73.10
PICARD 73.11
1 change: 1 addition & 0 deletions RunJob.py
Original file line number Diff line number Diff line change
Expand Up @@ -1910,6 +1910,7 @@ def sig2exc(sig, frm):
if count >= max_count:
benchmark_subprocess.send_signal(signal.SIGUSR1)
tolog("Terminated the benchmark since it ran for longer than %d s" % (max_count*_sleep))
break
else:
count += 1

Expand Down

0 comments on commit 7e4b8f8

Please sign in to comment.