Fix below-zero-generation-in-existing-chunks #11570
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How exactly did you get to mobs_spawned? The equivalent for full in pre 1.14-ish versions would be |
|
i generated a world in 1.12.2 made sure to wait a bit and also flew around in spectator mode in the ground to make sure everything was generated. i also tried the same in 1.17 and when i checked there the chunks were showing up as full (should note that i used single player to generate this) |
|
Pretty sure if you if you did the same with a 1.14 world it would break again, it's kind of awkward to have the check before datafixing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11531
i am not entirely sure what exactly is happening here. my best guess is that the chunk status "full" didn't yet exist in older versions and fully generated chunks were just left on "mobs_spawned".