Fix getMaxHeight to be exclusive instead of inclusive to match docs

[MrPowerGamerBR]

The getMaxHeight docs says that the value is exclusive, not inclusive. This has changed in 1.21.3 and since 1.21.3 the value is now inclusive due to Mojang changes. This patch changes the value to be exclusive by +1 the returned value from NMS.

Worth noting that this needs to be tested! I haven't tested it yet, and I seen that there are some CraftBukkit code that does call getMaxHeight (setBiome)

Fixes #11674

[Lulu13022002]

This is not the only method affected:
Chunk#getBlock/getChunkSnapshot are now inclusive, nvm got confused by what you called exclusive compared to the doc
Chunk#getEmptyChunkSnapshot throw an ArrayIndexOutOfBoundsException with your changes (at y = getMaxHeight) instead of the IllegalArgumentException

[NonSwag]

Wouldn't it be smarter to adjust the docs instead of the method?

[electronicboy]

No, the API docs describe the contract of the method, there is no sane justification for changing the API contract here

[MrPowerGamerBR]

This is not the only method affected: Chunk#getBlock/getChunkSnapshot are now inclusive, nvm got confused by what you called exclusive compared to the doc Chunk#getEmptyChunkSnapshot throw an ArrayIndexOutOfBoundsException with your changes (at y = getMaxHeight) instead of the IllegalArgumentException

Looks like I ended up checking only getMaxHeight usages on the API module, not on the server...

Well now this is a bit trickier, I don't know if I should assume that all getMaxHeight on the server are assuming that the value will be inclusive (new docs) or exclusive (old docs).

Wouldn't it be smarter to adjust the docs instead of the method?

Plugins already rely on the behavior of the current docs, I found this issue because my plugin stopped checking for the block at the top of the world due to this, so I dug deeper to find what was causing the issue and, while I found out that checking world.minHeight..world.maxHeight did fix the issue, that's not what I expected according to the docs and what I was expecting when I coded the plugin years ago. Other plugins also have issues due to this change, like mcMMO.

for (y in world.minHeight until world.maxHeight) {
   ...
}

[jacob1]

I ran into this same issue while updating Dynmap. I reported it to Spigot and it's fixed upstream now.

Looks like an identical patch to this one. Any potential issues included.

[Machine-Maker]

I think the issue also exists for WorldInfo#getMaxHeight

[Lulu13022002]

I just checked all the usages and the issue has been fixed in 1.21.4 (technically latest commit of 1.21.3 with paper fixes), thanks for the report regardless.