Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed attachment statistics for sqlite #847

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

Treeed
Copy link
Contributor

@Treeed Treeed commented Feb 2, 2025

SQLite doesn't support the backslash as an escape character by default. Any escape character must be specified by the ESCAPE function. To avoid confusion when using other DBs which do recognize the backslash, but also the ESCAPE function I used # here.

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.83%. Comparing base (d093721) to head (5bb79b5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #847      +/-   ##
============================================
- Coverage     60.85%   60.83%   -0.02%     
  Complexity     5931     5931              
============================================
  Files           523      523              
  Lines         20089    20089              
============================================
- Hits          12225    12222       -3     
- Misses         7864     7867       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Treeed Treeed mentioned this pull request Feb 2, 2025
@jbtronics
Copy link
Member

Looks good. Thank you.

@jbtronics jbtronics merged commit edf50a7 into Part-DB:master Feb 2, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants