-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show result path & refactor result component #38
Conversation
Hey @benediktms , This PR refactors the results component, Separates the logic & adds path on right side of full drive search. |
@ParthJadhav I think it looks good, some suggestions I have:
What do you think? |
I actually didn't understand what |
Sorry I meant version control repos like git. But I thought maybe it would be a good to be version control agnostic. But probably that can be added if and when it's needed. We could just start with git. |
I'll work on it tomorrow 🤝 |
I still quite didn't understand... Can u give me an example? |
currently only 2 parent folders are displayed:
Both options are fine but probably option 2 is better. In cases where the total path name is very long, we should truncate the final output to not clutter the UI. E.g.:
could become
otherwise depending on how deeply nested the file is, the full file path might not fit in the results view because it is too wide. |
Gotcha, I'll create a different Issue for that... |
Will merge this @benediktms |
closes: #33