Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertisement in video player #35

Closed
Ash258 opened this issue Jun 17, 2017 · 3 comments
Closed

Advertisement in video player #35

Ash258 opened this issue Jun 17, 2017 · 3 comments

Comments

@Ash258
Copy link

Ash258 commented Jun 17, 2017

After you allow ads on videos, ads are not working.
When ad should be played, playback just stops (no ad playing just pause) and you have to resume playback.

@ParticleCore
Copy link
Owner

I cannot replicate this problem.

Any issue that fails to follow these instructions will be automatically closed and marked as invalid:

https://github.com/ParticleCore/Iridium/blob/master/CONTRIBUTING.md#opening-a-new-issue

@adeep
Copy link
Contributor

adeep commented Jun 20, 2017

I have this problem too.
You can replicate this problem by disabling "play videos automatically" and enabling "Allow ads only on videos of subscribed channels"
When video slider reach yellow ads indicator, i guess its try to show video ads but can't make it and then video stopsand play button appears. Maybe it can't replicate when just jumping to ads part, because of Youtube not show ads instantly when jump that minute.

@ParticleCore
Copy link
Owner

With videos autoplay disabled I was able to finally find a video ad to trigger the problem and I think I have fixed it, but the release will take some time since I am in the middle of development of a big feature.

@ParticleCore ParticleCore reopened this Jun 20, 2017
ParticleCore added a commit that referenced this issue Jun 25, 2017
Feature added: Enable blacklist
Improved: Return to video page of always playing video
Fixed: Subtitles disabled occasionally not disabling
Closes #39
Closes #35
Closes #36
@ParticleCore ParticleCore added fixed and removed fixed labels Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants