-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings' changes don't persist if you don't close or reload all open youTube tabs/pages... #44
Comments
I am using the same Tampermonkey version on latest Chrome stable (59) and I cannot replicate your problem and it has never happened on Firefox or Chrome since the development started. Please try with the Chrome stable version to rule out any problems that the Tampermonkey might be having with the Chrome beta version. Also do follow the instructions exactly like they are detailed, including disabling all extensions - no exceptions, apart from Iridium - and testing with a new Chrome profile: https://github.com/ParticleCore/Iridium/wiki/Report-a-bug#troubleshooting Without a way to replicate this problem I cannot solve it, so please find a way to replicate this problem with step by step instructions. |
I'm on the win7 x64 system right now and I cannot replicate the problem in any way I've tried. |
Update: |
Please follow the troubleshooting instructions. Just because you are on a different machine does not mean the problem cannot be migrating, if you use profiles then everything from your other browser will transfer to any Chrome browser you use. Follow the instructions and confirm that this problem is restricted to Iridium and is not related to using a Beta version of Chrome + Tampermonkey. |
OK, Tried with
This also happens later on, when you make a new settings' change. The settings remain at the previous state unless you close all youtube tabs right after you alter a setting. |
Oooh I think I get what is going on now. Unless you refresh all the opened tabs after changing the settings, whichever settings those tabs had before they were changed in the iridium settings page will override the new ones when any feature is used; let's say change volume using the mouse wheel. This is because currently there is no way to propagate the new settings from the settings page to any of the opened tabs, meaning that all of those tabs are still using the settings prior to your changes (not good). Am I correct in saying that if you have all YouTube tabs closed - just like your last line said - when you change settings OR if you refresh all YouTube tabs without doing anything else (like changing a video or changing player size/volume, etc.) after changing settings the settings are not reset? If so then I really need to find a way to work around this, this is not a good experience. |
Yes, you are correct. But: One solution I've seen from another Chrome extension (sadly it's not open source) is this: |
Yeah but this is a userscript, it is extremely limited when compared with an extension, it can't just read tabs like that, but I will find a way. Thanks for being so patient with this, this definitely needs to be improved. Until that happens I'd suggest that you either refresh all the tabs after changing anything in the settings tab or changing with no opened tabs, since we know those will have the previous settings persisting until they are refreshed. |
In the latest version the settings should update throughout any opened YouTube tabs running Iridium, but due to some strange behavior with the Tampermonkey userscript manager, saving new data and fetching it really quick from a different tab was returning the old data, so the process overall has a delay of 1.5s, which I believe to be more than enough. This is not failure proof, there might be certain scenarios where the old settings might persist in this way, but I believe this case will be rare. Let me know if this experience is now better for you as well. |
I don't know if this is a known issue or not. Excuse me if it is.
I've been using the latest script and I found that Iridium settings don't save correctly.
The behavior isn't fully reproducible, because I found it to be very inconsistent.
Sometimes settings don't stick even with one YouTube tab open. You open the settings, make your changes, close the settings tab, then reopen them and the settings are reset.
Other times they do stick around if I reopen them, but when I close the YouTube tab and open another, I find that the settings are reset.
The most common case is when I close and reopen the browser. That way options are reset to defaults.
I'll be happy to try out any suggestions, or share any info that might be useful to resolve this.
I've tested this on 2 systems. One with win7 x64 and another with win10 x64. Both with latest Chrome Beta: Version 60.0.3112.40 (Official Build) beta (64-bit)
and both with latest Tampermonkey Stable 4.3.6
No other userscripts are running besides Iridium, and no other chrome extensions that mess up YouTube are running either.
The text was updated successfully, but these errors were encountered: