Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename video previews to avoid confusion with YouTube's equivalent #84

Closed
MattSturgeon opened this issue Jul 24, 2017 · 2 comments
Closed

Comments

@MattSturgeon
Copy link

YouTube has added video previewing on thumbnail hover (currently also implemented by iridium).

YouTube material now shows an approximate two second clip of the video when hovering over a thumbnail, before returning to the static thumbnail.

This means that even if video previews are turned off, they will still be on for vanilla youtube.

It may be worth looking into a setting to disable the youtube equivalent when Iridium's is off, since it may be confusing to turn off previews, yet still have them.

Alternatively you could simply disable the youtube version completely and just have users toggle your version. You could even rebuild your version on top of youtube's, if you are a perfectionist!

@ParticleCore
Copy link
Owner

Yeah, I was already aware of it before I decided to implement it and was on it once it went live: #63

I agree that as of now this might cause some confusion, I might rename it to "full video previews" to distinguish from YouTube's impelementation.

@MattSturgeon
Copy link
Author

MattSturgeon commented Jul 24, 2017

Yeah, I was already aware of it before

Oops didn't spot #63 - my bad. Funny thing is I've looked at 2d8ef94 a few times before, never noticed from the commit message that it had anything to do with video previews... That's why I like commits to be small, single purpose, and well summarised, but I won't go off on a rant again ;)

I might rename it to "full video previews" to distinguish from YouTube's impelementation.

+1 I'll rename this issue to that and open a separate feature request for fully disabling, in case anyone wants that.

EDIT: See also #85

@MattSturgeon MattSturgeon changed the title [FYI] Thumbnail video preview also implemented by YT Rename video previews to avoid confusion with YouTube's equivalent Jul 24, 2017
ParticleCore added a commit that referenced this issue Jul 27, 2017
Closes #86
Closes #84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants