Fix propTypes warning #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekmisler
reviewed
Feb 10, 2022
| @@ -114,7 +114,8 @@ | |||
| ], | |||
| "testMatch": [ | |||
| "**/src/**/__tests__/**/*.[jt]s?(x)", | |||
| "**/src/**/?(*.)+(spec|test).[jt]s?(x)" | |||
| "**/src/**/?(*.)+(spec|test).[jt]s?(x)", | |||
| "**/test/**?(*.)+(spec|test).[jt]s?(x)" | |||
There was a problem hiding this comment.
Do you mind if we stick with the __tests__ pattern? It's a Jest standard, and the underscores make it easier to visually scan the folder structure when looking for files
There was a problem hiding this comment.
I added this because the existing integration tests live in the test folder and weren't being run.
Probably would just be better to do a complete pass and rename all folders named test as a followup, yeah? I can submit a followup PR if so.
There was a problem hiding this comment.
ohh, that's crazy, i didn't know about the /test/!
derekmisler
approved these changes
Feb 10, 2022
jnoh
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we copy all the properties of the wrapped component when wrapping it with nion, including propTypes. This causes situations where the wrapped component (correctly) declares that it requires the
nionprop and this gets propagated to the connected component as well, which should not require thenionprop since it injects it to its child.This PR fixes this issue by stripping the
nionpropType, if it exists, from the connected component.