Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated readme #205

Merged
merged 6 commits into from
Jan 8, 2016
Merged

updated readme #205

merged 6 commits into from
Jan 8, 2016

Conversation

samvloeberghs
Copy link
Contributor

master...samvloeberghs:master#diff-04c6e90faac2675aa89e2176d2eec7d8L49:

When you follow the guide and you install typings globally, you don't need to reference it into node modules, right?

master...samvloeberghs:master#diff-04c6e90faac2675aa89e2176d2eec7d8L54

I just followed you guys setup description and http://0.0.0.0:3000 doesn't work by default on a Windows machine. So I've added http://localhost:3000.

Grtz

@samvloeberghs
Copy link
Contributor Author

I've just spotted the use of 0.0.0.0 in the webpack config files as well.
https://github.com/AngularClass/angular2-webpack-starter/blob/master/webpack.prod.config.js#L19
https://github.com/AngularClass/angular2-webpack-starter/blob/master/webpack.config.js#L18

Is it ok to just use localhost? On a Windows machine, the use of 0.0.0.0 is breaking functionality hard.

@PatrickJS
Copy link
Owner

0.0.0.0 was used for virtual machines but we can change it back and I'll just add it to FAQ.

@@ -46,12 +46,12 @@ cd angular2-webpack-starter
npm install

# install TypeScript typings
./node_modules/.bin/typings install
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you leave this

@samvloeberghs
Copy link
Contributor Author

done but please validate
(i'll remember to rebase next time)

@PatrickJS
Copy link
Owner

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants