-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated readme #205
updated readme #205
Conversation
I've just spotted the use of 0.0.0.0 in the webpack config files as well. Is it ok to just use localhost? On a Windows machine, the use of 0.0.0.0 is breaking functionality hard. |
|
@@ -46,12 +46,12 @@ cd angular2-webpack-starter | |||
npm install | |||
|
|||
# install TypeScript typings | |||
./node_modules/.bin/typings install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you leave this
done but please validate |
thanks! |
master...samvloeberghs:master#diff-04c6e90faac2675aa89e2176d2eec7d8L49:
When you follow the guide and you install typings globally, you don't need to reference it into node modules, right?
master...samvloeberghs:master#diff-04c6e90faac2675aa89e2176d2eec7d8L54
I just followed you guys setup description and http://0.0.0.0:3000 doesn't work by default on a Windows machine. So I've added http://localhost:3000.
Grtz