Feature/Giphy integration #63
Conversation
| useEffect(() => { | ||
| gifSearchInput.length > 2 && | ||
| axios | ||
| .get( | ||
| `https://api.giphy.com/v1/gifs/search?api_key=0kVBw2UV1wx2rzelZSio79c1iKQqdZpt&q=${gifSearchInput}&limit=18&offset=0&rating=g&lang=en` | ||
| ) |
There was a problem hiding this comment.
This code could be hook.
|
@voinar Rename PR and branch, add "feature/" prefix to both. |
| ); | ||
|
|
||
| useEffect(() => { | ||
| const getGifsList = async () => { |
There was a problem hiding this comment.
For me there should be error handling. Because when no response (giphy is down or w/e) the response.data.data will be probably null or undefined or error ocures because we want to acces to a property that doesn't exist. And there is expected type to be IGifWidget[].
There was a problem hiding this comment.
He should create error handling for all requests, but he know about it ;)
PatrykKuniczak
force-pushed
the
giphy-integration
branch
from
47e3a0d to
36a5ecb
Compare
| <GifWidgetFooter> | ||
| <span>Powered by</span> | ||
| <img | ||
| style={{ width: "5rem" }} |
There was a problem hiding this comment.
Get rid of inline style
There was a problem hiding this comment.
This is only style which this img contain, i think this is good idea, i know to hold styles into css, but for that i think it's good, we have on users list loading also styled like this, if i must refactor that, then u also must refactor on users list, for hold every style into css files, in our case in styled component
| } from "./GifWidget.styled"; | ||
| import GiphyAttributionLogoImage from "assets/GiphyAttributionLogo.png"; | ||
|
|
||
| type TGifWidget = { toggleGifWidgetVisibility: () => void }; |
There was a problem hiding this comment.
Use interface like everywhere
| background-color: transparent; | ||
|
|
||
| pointer-events: ${props => (props.gifWidgetVisible ? "none" : "auto")}; |
There was a problem hiding this comment.
| pointer-events: ${props => (props.gifWidgetVisible ? "none" : "auto")}; | |
| pointer-events: ${({gifWidgetVisible}) => gifWidgetVisible ? "none" : "auto"}; |
#2
foundation for giphy integration. features to be added: