Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create workflow does not run as expected #58

Closed
arr00 opened this issue Aug 28, 2024 · 4 comments
Closed

create workflow does not run as expected #58

arr00 opened this issue Aug 28, 2024 · 4 comments
Labels
priority: 1 This is important. It should be dealt with shortly. type: bug Something isn't working. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.

Comments

@arr00
Copy link
Contributor

arr00 commented Aug 28, 2024

I'm not sure how the create workflow is intended to run, but in a test repo I created it is a bit odd. The create workflow does not run on the initial creation of the new repo, it only runs when you create a new branch or tag. I would expect it to run automatically on main with the initial commit.

Forked the template and switched to the push trigger and all worked as expected. https://github.com/arr00/test-new-template.

@PaulRBerg PaulRBerg added priority: 1 This is important. It should be dealt with shortly. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. type: bug Something isn't working. labels Aug 29, 2024
@PaulRBerg
Copy link
Owner

Good catch. The create workflow no longer works as expected.

It should be run when creating a new template via GitHub's Use this Template button.

The workflow was added by @ahmedali8. Maybe he can lend us a hand here? :D

@arr00
Copy link
Contributor Author

arr00 commented Aug 29, 2024

push is the only trigger that mentions creating a repo from a template--I believe the conditional push trigger is the way to go.

@arr00
Copy link
Contributor Author

arr00 commented Aug 30, 2024

Issue is relevant for https://github.com/PaulRBerg/hardhat-template as well.

@PaulRBerg
Copy link
Owner

Thanks

PaulRBerg added a commit to PaulRBerg/hardhat-template that referenced this issue Sep 2, 2024
unionmini added a commit to unionmini/hardhat-template that referenced this issue Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: 1 This is important. It should be dealt with shortly. type: bug Something isn't working. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.
Projects
None yet
Development

No branches or pull requests

2 participants