Skip to content

Commit

Permalink
Remove redundant steps in e2e tests (facebook#3747)
Browse files Browse the repository at this point in the history
* This doesn't look needed anymore

* Remove unnecessary rebuilds
  • Loading branch information
Timer authored and Pavel Zhytko committed Jul 10, 2018
1 parent f259c67 commit a37aebf
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 30 deletions.
12 changes: 1 addition & 11 deletions tasks/e2e-installs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -73,18 +73,8 @@ then
npm cache clean || npm cache verify
fi

# Prevent bootstrap, we only want top-level dependencies
cp package.json package.json.bak
grep -v "postinstall" package.json > temp && mv temp package.json
# Bootstrap monorepo
yarn
mv package.json.bak package.json

# We removed the postinstall, so do it manually
node bootstrap.js

cd packages/react-error-overlay/
yarn run build:prod
cd ../..

# ******************************************************************************
# First, publish the monorepo.
Expand Down
12 changes: 1 addition & 11 deletions tasks/e2e-kitchensink.sh
Original file line number Diff line number Diff line change
Expand Up @@ -65,18 +65,8 @@ then
npm cache clean || npm cache verify
fi

# Prevent bootstrap, we only want top-level dependencies
cp package.json package.json.bak
grep -v "postinstall" package.json > temp && mv temp package.json
# Bootstrap monorepo
yarn
mv package.json.bak package.json

# We removed the postinstall, so do it manually
node bootstrap.js

cd packages/react-error-overlay/
yarn build:prod
cd ../..

# ******************************************************************************
# First, publish the monorepo.
Expand Down
9 changes: 1 addition & 8 deletions tasks/e2e-simple.sh
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,8 @@ then
npm cache clean || npm cache verify
fi

# Prevent bootstrap, we only want top-level dependencies
cp package.json package.json.bak
grep -v "postinstall" package.json > temp && mv temp package.json
# Bootstrap monorepo
yarn
mv package.json.bak package.json

# Start local registry
tmp_registry_log=`mktemp`
Expand All @@ -96,9 +93,6 @@ yarn config set registry http://localhost:4873
# Login so we can publish packages
npx [email protected] -u user -p password -e [email protected] -r http://localhost:4873 --quotes

# We removed the postinstall, so do it manually here
node bootstrap.js

# Lint own code
./node_modules/.bin/eslint --max-warnings 0 packages/babel-preset-react-app/
./node_modules/.bin/eslint --max-warnings 0 packages/create-react-app/
Expand All @@ -108,7 +102,6 @@ node bootstrap.js
cd packages/react-error-overlay/
./node_modules/.bin/eslint --max-warnings 0 src/
yarn test
yarn build:prod
cd ../..
cd packages/react-dev-utils/
yarn test
Expand Down

0 comments on commit a37aebf

Please sign in to comment.