Fixes

PayU · Mar 9, 2021 · 13cda73 · 13cda73
1 parent 3d4c486
commit 13cda73
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/src/metrics-middleware.js b/src/metrics-middleware.js
@@ -56,6 +56,7 @@ module.exports = (appVersion, projectName, framework = 'express') => {
         });
 
         setupOptions.includeQueryParams = includeQueryParams;
+
         setupOptions.defaultMetricsInterval = defaultMetricsInterval;
 
         setupOptions.additionalLabels = utils.validateInput({
@@ -118,9 +119,6 @@ module.exports = (appVersion, projectName, framework = 'express') => {
         const defaultMetricLabels = ['method', 'route', 'code'];
 
         const metricLabels = [
-            'method',
-            'route',
-            'code',
             ...additionalLabels,
             ...excludeDefaultMetricLabels === true
                 ? []

diff --git a/test/unit-test/metric-middleware-koa-test.js b/test/unit-test/metric-middleware-koa-test.js
@@ -812,10 +812,11 @@ describe('metrics-middleware', () => {
                 expect(Prometheus.register.getSingleMetric('http_request_size_bytes').labelNames).to.have.members(['method']);
             });
             it('and it\'s other type', () => {
-                middleware({
-                    excludeDefaultMetricLabels: 'invalid'
-                });
-                expect(Prometheus.register.getSingleMetric('http_request_size_bytes').labelNames).to.have.members(['method', 'route', 'code']);
+                expect(() => {
+                    middleware({
+                        excludeDefaultMetricLabels: 'invalid',
+                    });
+                }).to.throw('excludeDefaultMetricLabels should be an array or a boolean');
             });
             afterEach(() => {
                 Prometheus.register.clear();