Skip to content

Commit

Permalink
Improve nvm_download_artifact() process, fix nvm-sh#1291
Browse files Browse the repository at this point in the history
 - Delete broken/checksum not matched local cache
 - More output message.
  • Loading branch information
PeterDaveHello committed Nov 8, 2016
1 parent 9c92b5a commit 01cb746
Showing 1 changed file with 17 additions and 3 deletions.
20 changes: 17 additions & 3 deletions nvm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -1725,9 +1725,23 @@ nvm_download_artifact() {
TARBALL_URL="${MIRROR}/${SLUG}.tar.${COMPRESSION}"
fi

if nvm_compare_checksum "${TARBALL}" "${CHECKSUM}" >/dev/null 2>&1; then
nvm_err "Checksums match! Using existing downloaded archive $(nvm_sanitize_path "${TARBALL}")"
else
local USE_LOCAL_TARBALL
if [ -r "${TARBALL}" ]; then
nvm_err "Local cache found:"
nvm_err "$(nvm_sanitize_path "${TARBALL}")"
if nvm_compare_checksum "${TARBALL}" "${CHECKSUM}" >/dev/null 2>&1; then
nvm_err "Checksums match! Using existing downloaded archive $(nvm_sanitize_path "${TARBALL}")"
USE_LOCAL_TARBALL=true
nvm_echo "${TARBALL}"
return 0
fi
nvm_compare_checksum "${TARBALL}" "${CHECKSUM}"
nvm_err "Checksum check failed!"
nvm_err "Removing the broken local cache..."
command rm -rf "${TARBALL}"
nvm_err "Downloading ${TARBALL_URL} ..."
fi
if [ "${USE_LOCAL_TARBALL-}" != true ]; then
nvm_echo "Downloading ${TARBALL_URL}..."
nvm_download -L -C - --progress-bar "${TARBALL_URL}" -o "${TARBALL}" || (
command rm -rf "${TARBALL}" "${tmpdir}"
Expand Down

0 comments on commit 01cb746

Please sign in to comment.