Prevent duble globbing #111

spirillen · 2024-12-17T19:12:03Z

Closes #110

Summary by CodeRabbit

Bug Fixes
- Updated error message output for unsorted files to improve clarity.
Chores
- Maintained existing logic and functionality for checking file sorting and outputting differences.

coderabbitai · 2024-12-17T19:12:15Z

📝 Walkthrough

Walkthrough

The changes involve modifying the error message output in the sorting test script located in tests/sort. The primary modification is in the way the file name is displayed in the error message, removing quotation marks and adjusting the phrasing. The core functionality of checking file sorting remains unchanged, with the script continuing to use a temporary file for diff output and performing cleanup operations.

Changes

File	Change Summary
`tests/sort`	Updated error message formatting when files are unsorted

Assessment against linked issues

Objective	Addressed	Explanation
Prevent double globbing [#110]	✅
Fix typo in error message	❓	No evidence of fixing the "proerly" typo mentioned in the issue

The changes align with the suggestion to simplify the echo command by removing unnecessary quotation marks around the file variable. However, the specific typo mentioned in the issue description does not appear to have been addressed in this commit.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8d52aa1 and be7f3b0.

📒 Files selected for processing (1)

tests/sort (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

tests/sort

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Removed `420.bio` as it is no longer active Signed-off-by: spirillen <[email protected]>

```python knw.one INACTIVE STDLOOKUP Unknown Unknown AVAILABILITY wi.se ACTIVE DNSLOOKUP Unknown Unknown AVAILABILITY toyota.us INACTIVE STDLOOKUP Unknown Unknown AVAILABILITY mstr.cd INACTIVE STDLOOKUP Unknown Unknown AVAILABILITY ``` Signed-off-by: spirillen <[email protected]>

PeterDaveHello

Maybe we just keep e212e9a here?

list

Fix https://github.com/PeterDaveHello/url-shorteners/pull/111/files#r1890437810 Signed-off-by: spirillen <[email protected]>

PeterDaveHello · 2024-12-22T16:07:51Z

tests/sort

@@ -6,7 +6,7 @@ pass=true

 for file in list inactive; do
    if ! diff --color=always -u <(grep -v -E '^(#|$)' "$file") <(grep -v -E '^(#|$)' "$file" | sort) > "$tempfile"; then
-        echo -e "\nFile \"$file\" not proerly sorted!\n\nDiff between current and the correct version:" 1>&2
+        echo -e "\nFile $file not proerly sorted!\n\nDiff between current and the correct version:" 1>&2


The result/behavior seems to be changed as below. Maybe #110 is a misunderstanding?

- File "list" not proerly sorted! + File list not proerly sorted!

The word list have never been present. but happy to add it

Oh, I mean the output of the script, in the script, it's in the for loop variable.

Fixed the grammar and wording according to PeterDaveHello#111 (comment) Signed-off-by: spirillen <[email protected]>

Prevent duble globbing

e212e9a

Closes PeterDaveHello#110

dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 17, 2024

dosubot bot added the bug Something isn't working label Dec 17, 2024

coderabbitai bot approved these changes Dec 17, 2024

View reviewed changes

spirillen added 2 commits December 17, 2024 20:35

420.bio

50b7d9e

Removed `420.bio` as it is no longer active Signed-off-by: spirillen <[email protected]>

PeterDaveHello requested changes Dec 18, 2024

View reviewed changes

list Outdated Show resolved Hide resolved

spirillen added 2 commits December 18, 2024 18:13

Merge branch 'PeterDaveHello:master' into patch-1

885ec6d

restore list

483da00

Fix https://github.com/PeterDaveHello/url-shorteners/pull/111/files#r1890437810 Signed-off-by: spirillen <[email protected]>

PeterDaveHello reviewed Dec 22, 2024

View reviewed changes

Updated wording in sort

be7f3b0

Fixed the grammar and wording according to PeterDaveHello#111 (comment) Signed-off-by: spirillen <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevent duble globbing #111

Prevent duble globbing #111

spirillen commented Dec 17, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 17, 2024 •

edited

Loading

Walkthrough

Changes

Assessment against linked issues

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

PeterDaveHello left a comment

PeterDaveHello Dec 22, 2024

spirillen Dec 22, 2024

PeterDaveHello Dec 22, 2024

Prevent duble globbing #111

Are you sure you want to change the base?

Prevent duble globbing #111

Conversation

spirillen commented Dec 17, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Dec 17, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

PeterDaveHello left a comment

Choose a reason for hiding this comment

PeterDaveHello Dec 22, 2024

Choose a reason for hiding this comment

spirillen Dec 22, 2024

Choose a reason for hiding this comment

PeterDaveHello Dec 22, 2024

Choose a reason for hiding this comment

spirillen commented Dec 17, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 17, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)