Prevent duble globbing #111
Conversation
dosubot
bot
added
the
size:XS
📝 WalkthroughWalkthroughThe changes involve modifying the error message output in the sorting test script located in Changes
Assessment against linked issues
The changes align with the suggestion to simplify the echo command by removing unnecessary quotation marks around the file variable. However, the specific typo mentioned in the issue description does not appear to have been addressed in this commit. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Removed `420.bio` as it is no longer active Signed-off-by: spirillen <[email protected]>
```python knw.one INACTIVE STDLOOKUP Unknown Unknown AVAILABILITY wi.se ACTIVE DNSLOOKUP Unknown Unknown AVAILABILITY toyota.us INACTIVE STDLOOKUP Unknown Unknown AVAILABILITY mstr.cd INACTIVE STDLOOKUP Unknown Unknown AVAILABILITY ``` Signed-off-by: spirillen <[email protected]>
tests/sort
Outdated
| @@ -6,7 +6,7 @@ pass=true | |||
|
|
|||
| for file in list inactive; do | |||
| if ! diff --color=always -u <(grep -v -E '^(#|$)' "$file") <(grep -v -E '^(#|$)' "$file" | sort) > "$tempfile"; then | |||
| echo -e "\nFile \"$file\" not proerly sorted!\n\nDiff between current and the correct version:" 1>&2 | |||
| echo -e "\nFile $file not proerly sorted!\n\nDiff between current and the correct version:" 1>&2 | |||
There was a problem hiding this comment.
The result/behavior seems to be changed as below. Maybe #110 is a misunderstanding?
- File "list" not proerly sorted!
+ File list not proerly sorted!There was a problem hiding this comment.
The word list have never been present. but happy to add it
There was a problem hiding this comment.
Oh, I mean the output of the script, in the script, it's in the for loop variable.
Fixed the grammar and wording according to PeterDaveHello#111 (comment) Signed-off-by: spirillen <[email protected]>
Closes #110
Summary by CodeRabbit
Bug Fixes
Chores