Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors and fonts #71

Merged
merged 2 commits into from
Aug 1, 2016
Merged

Colors and fonts #71

merged 2 commits into from
Aug 1, 2016

Conversation

Davvie
Copy link
Contributor

@Davvie Davvie commented Jul 22, 2016

This PR includes:

  1. text color for a selected cell can be set using selectedCellTextLabelColor. In some cases it's nice to have a different text color when the cell is selected. Like when you have black text and purple selection. Black doesn't look good on purple while white totally does.
  2. you can change the color of an arrow via arrowTintColor. It makes experimenting with colors easier, you don't have to manually update the image file every single time.
  3. navigation bar title can have a separate font which is set with navigationBarTitleFont. In iOS navigation titles are mostly semibold. But sometimes it doesn't make sense for the menu cells to be semibold as well. Why don't we have separate font settings for titles and cells?

(And I added these changes to BTConfiguration as well)

Thank you for a great library, it's been a joy for me to use and tweak it :)

David added 2 commits July 23, 2016 02:42
- Arrow color can be changed using arrowTintColor property;
- Navigation bar and dropdown table use different fonts. Navigation bar title font can be set via navigationBarTitleFont property
@PhamBaTho PhamBaTho merged commit b571bb6 into PhamBaTho:master Aug 1, 2016
@PhamBaTho
Copy link
Owner

@Davvie nice ideas and very well PR. This've been merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants