Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain non-migratable annotation arguments with a warning comment #37

Conversation

Philzen
Copy link
Owner

@Philzen Philzen commented Jun 21, 2024

Closes #4

Will retain the TestNG annotation with those attribute arguments that cannot be migrated (yet) as a fully qualified annotation incl. a warning comment.

Example:

/* ❗️ ❗️ ❗️
   At least one `@Test`-attribute could not be migrated to JUnit 5. Kindly review the remainder below
   and manually apply any changes you may require to retain the existing test suite's behavior. Delete
↓  the annotation and this comment when satisfied, or use `git reset --hard` to roll back the migration.

   If you think this is a mistake or have an idea how this migration could be implemented instead, any
   feedback to https://github.com/Philzen/rewrite-TestNG-to-JUnit5/issues will be greatly appreciated.
*/
@org.testng.annotations.Test(threadPoolSize = 8)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/philzen/oss/testng/UpdateTestAnnotationToJunit5.java
    • lines 21-22

@Philzen Philzen force-pushed the 4-ensure-testng-test-attributes-that-are-not-migratable-remain-after-migration branch from af32071 to 158ceca Compare June 22, 2024 00:03
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/philzen/oss/testng/UpdateTestAnnotationToJunit5.java
    • lines 21-22

@Philzen Philzen force-pushed the main branch 26 times, most recently from 0cb2832 to b823f0a Compare June 24, 2024 10:49
@Philzen Philzen force-pushed the 4-ensure-testng-test-attributes-that-are-not-migratable-remain-after-migration branch from 158ceca to 10e1ab0 Compare June 24, 2024 11:10
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/philzen/oss/testng/UpdateTestAnnotationToJunit5.java
    • lines 21-22

@Philzen Philzen force-pushed the main branch 2 times, most recently from e1693ef to e5630dd Compare June 24, 2024 11:16
@Philzen Philzen force-pushed the 4-ensure-testng-test-attributes-that-are-not-migratable-remain-after-migration branch from 10e1ab0 to 32f0e20 Compare June 24, 2024 11:16
Copy link

sonarcloud bot commented Jun 24, 2024

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/philzen/oss/testng/UpdateTestAnnotationToJunit5.java
    • lines 21-22

@Philzen Philzen merged commit 6abd88d into main Jun 24, 2024
5 checks passed
@Philzen Philzen deleted the 4-ensure-testng-test-attributes-that-are-not-migratable-remain-after-migration branch June 24, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure testng @Test attributes that are not migratable remain after migration
1 participant