-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retain non-migratable annotation arguments with a warning comment #37
Retain non-migratable annotation arguments with a warning comment #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/philzen/oss/testng/UpdateTestAnnotationToJunit5.java
- lines 21-22
src/main/java/org/philzen/oss/testng/UpdateTestAnnotationToJunit5.java
Outdated
Show resolved
Hide resolved
src/main/java/org/philzen/oss/testng/UpdateTestAnnotationToJunit5.java
Outdated
Show resolved
Hide resolved
src/main/java/org/philzen/oss/testng/UpdateTestAnnotationToJunit5.java
Outdated
Show resolved
Hide resolved
af32071
to
158ceca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/philzen/oss/testng/UpdateTestAnnotationToJunit5.java
- lines 21-22
0cb2832
to
b823f0a
Compare
158ceca
to
10e1ab0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/philzen/oss/testng/UpdateTestAnnotationToJunit5.java
- lines 21-22
e1693ef
to
e5630dd
Compare
10e1ab0
to
32f0e20
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/philzen/oss/testng/UpdateTestAnnotationToJunit5.java
- lines 21-22
Closes #4
Will retain the TestNG annotation with those attribute arguments that cannot be migrated (yet) as a fully qualified annotation incl. a warning comment.
Example: