pills: Optimize removePill function.

The removePill function of input_pill module uses a for loop for iterating and finding the required pill. Replace the for loop with inbuilt findIndex function for efficiency. Authored-by: Dhruv Chouhan <[email protected]>.
PieterCK · May 17, 2024 · 6af748f · 6af748f
1 parent ac7dd6f
commit 6af748f
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/web/src/input_pill.ts b/web/src/input_pill.ts
@@ -222,14 +222,9 @@ export function create<T>(opts: InputPillCreateOptions<T>): InputPillContainer<T
         // this would generally be used for DOM-provoked actions, such as a user
         // clicking on a pill to remove it.
         removePill(element: HTMLElement) {
-            let idx: number | undefined;
-            for (let x = 0; x < store.pills.length; x += 1) {
-                if (store.pills[x].$element[0] === element) {
-                    idx = x;
-                }
-            }
+            const idx = store.pills.findIndex((pill) => pill.$element[0] === element);
 
-            if (idx !== undefined) {
+            if (idx !== -1) {
                 store.pills[idx].$element.remove();
                 const pill = store.pills.splice(idx, 1);
                 if (store.onPillRemove !== undefined) {