Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publisher): add retry for tiup publishing #209

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Dec 4, 2024

Enhance the stability.

Signed-off-by: wuhuizuo [email protected]

Enhance the stability.

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot requested a review from purelind December 4, 2024 12:49
Copy link

ti-chi-bot bot commented Dec 4, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and description, the key change is adding retry when publishing to Tiup mirror. The change added a new constant tiupUploadingMaxRetries and tiupUploadingRetryDelay, and modified the handle function to add retry logic when publishing.

There are no apparent potential issues with the changes. However, it may be worth considering adding a timeout parameter to the retry logic to avoid long waiting times.

One suggestion for improvement would be to add more descriptive log messages to help with debugging in case of failures. Additionally, adding error handling for the time.Sleep function calls could be beneficial.

Overall, the changes look good, and I recommend merging the pull request.

@ti-chi-bot ti-chi-bot bot added the size/S label Dec 4, 2024
Copy link

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 4, 2024
Copy link

ti-chi-bot bot commented Dec 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-04 14:07:23.259146654 +0000 UTC m=+1250230.878801169: ☑️ agreed by purelind.

@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Dec 5, 2024

/approve

Copy link

ti-chi-bot bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit 8c2a836 into main Dec 5, 2024
7 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/add-retry-for-tiup-publishing branch December 5, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants