Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudevents-server): do not send the canceled pr and tr to lark #216

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

wuhuizuo
Copy link
Contributor

No description provided.

Copy link

ti-chi-bot bot commented Dec 26, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title, the changes made to the code are related to not sending the canceled pr and tr to the lark. After reviewing the diff, I can see that the changes made to the code are in the handler.go and lark.go files of the cloudevents-server package.

In handler.go, the changes are related to adding conditions to check whether the pr and tr are canceled or not before filling in the card message info. If the pr or tr is canceled, the function will return nil. In lark.go, the changes are related to adding a check to handle the case where the card message info is nil.

The changes look good and the logic seems to be correct. However, it would be helpful if the pull request had more information in the description, such as why this change was made and what problem it solves.

One suggestion for improvement would be to add test cases to cover the scenarios where the pr and tr are canceled. This will ensure that the changes made to the code work as expected.

@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Dec 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit 9e14d2a into main Dec 26, 2024
7 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/ignore-cancel-pipeline-run branch December 26, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant