Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publisher): support profile for tiup publications #217

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

wuhuizuo
Copy link
Contributor

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot ti-chi-bot bot requested a review from purelind December 30, 2024 07:51
Copy link

ti-chi-bot bot commented Dec 30, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and description, the changes are adding support for a profile in TiUP publications. Looking at the diff, it seems that there are only a few changes made to the funcs_tiup.go file. The changes include:

  • Adding a new regex pattern to ociGATagRegex to match a new pattern.
  • Modifying the transformTiupVer function to include a new case for the ociGATagRegex pattern.

The changes seem reasonable, and there are no obvious issues with the code. However, there are a few suggestions that I would like to make:

  • It would be helpful to add some comments to explain the new regex pattern and the new case added to the transformTiupVer function.
  • It would be good to check if all tests are passing after the changes are made.

Overall, the changes seem good, and the PR can be merged after addressing the suggestions mentioned above.

@ti-chi-bot ti-chi-bot bot added the size/XS label Dec 30, 2024
@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Dec 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 30, 2024
@ti-chi-bot ti-chi-bot bot merged commit 63c6b7f into main Dec 30, 2024
7 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/support-other-profile-for-tiup-publisher branch December 30, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant