Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tibuild): support profile for tekton engine #222

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Jan 24, 2025

This pull request includes a small change to the tibuild/pkg/rest/service/cloud_event_client.go file. The change adds a new extension parameter to the cloud event for the paramProfile field.

@ti-chi-bot ti-chi-bot bot requested a review from purelind January 24, 2025 06:24
Copy link

ti-chi-bot bot commented Jan 24, 2025

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and diff, the key change appears to be the addition of support for a profile in the Tekton engine. Specifically, this change adds a line of code to the newDevBuildCloudEvent function in the cloud_event_client.go file.

As for potential problems, it's difficult to say without more context or code changes. However, it's always a good idea to review the impact of new code on any existing functionality and to ensure that the change does not introduce any security vulnerabilities.

As for fixing suggestions, it would be helpful to have more context and information about what this change is intended to accomplish. It may also be helpful to review the relevant documentation or guidelines for adding new features to the project to ensure that the change is in line with project standards.

@ti-chi-bot ti-chi-bot bot added the size/XS label Jan 24, 2025
@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 24, 2025
@ti-chi-bot ti-chi-bot bot merged commit 8a17a7b into main Jan 24, 2025
6 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/tibuild/tekton-support-profile branch January 24, 2025 07:10
wuhuizuo added a commit to PingCAP-QE/ee-ops that referenced this pull request Jan 24, 2025
ti-chi-bot bot pushed a commit to PingCAP-QE/ee-ops that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant