Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tibuild): add debug log #224

Merged
merged 1 commit into from
Jan 29, 2025
Merged

chore(tibuild): add debug log #224

merged 1 commit into from
Jan 29, 2025

Conversation

wuhuizuo
Copy link
Contributor

No description provided.

@ti-chi-bot ti-chi-bot bot requested a review from purelind January 29, 2025 15:41
Copy link

ti-chi-bot bot commented Jan 29, 2025

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and diff, it appears that this change adds some debug logging to the CloudEventClient struct in the cloud_event_client.go file. Specifically, it logs the triggering of a dev build and the dev build event using slog.InfoContext.

One potential problem with this change is that it is adding more logging to the codebase, which could potentially impact performance and increase log noise. Additionally, there is no context provided in the pull request description to explain why this change is necessary or what problem it is solving.

A suggestion for fixing this change would be to provide more context in the pull request description about why this change is necessary and what problem it is solving. Additionally, it may be worth considering whether this additional logging is necessary, or if there are other ways to debug the system that may be less invasive. Finally, it would be useful to discuss with the development team whether the additional logging will have any negative impact on performance.

@ti-chi-bot ti-chi-bot bot added the size/XS label Jan 29, 2025
@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 29, 2025
@ti-chi-bot ti-chi-bot bot merged commit acdc94d into main Jan 29, 2025
6 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/add-debug-log branch January 29, 2025 15:48
wuhuizuo added a commit that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant