Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tibuild): move pkg/database to internal/database #225

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

wuhuizuo
Copy link
Contributor

Signed-off-by: wuhuizuo [email protected]

Copy link

ti-chi-bot bot commented Jan 29, 2025

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary of changes:

  • The pkg/database package has been moved to internal/database.
  • All import paths that previously pointed to pkg/database have been updated to point to internal/database.

Potential problems:

  • There might be other packages that still import from the old pkg/database path, which can cause build errors.

Fixing suggestions:

  • Check all files in the project and make sure that all import paths have been updated.
  • Run the test suite to ensure that there are no build errors caused by the path change.
  • If any errors are found, update the import paths accordingly.

@ti-chi-bot ti-chi-bot bot requested a review from purelind January 29, 2025 17:08
Copy link
Contributor Author

@wuhuizuo wuhuizuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ti-chi-bot ti-chi-bot bot added the size/S label Jan 29, 2025
Copy link

ti-chi-bot bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 29, 2025
@ti-chi-bot ti-chi-bot bot merged commit a0e6c34 into main Jan 29, 2025
6 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/refactor-tibuild branch January 29, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant