Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebP is not working on macOS builds #770

Closed
cameronwhite opened this issue Apr 17, 2024 Discussed in #769 · 5 comments
Closed

WebP is not working on macOS builds #770

cameronwhite opened this issue Apr 17, 2024 Discussed in #769 · 5 comments

Comments

@cameronwhite
Copy link
Member

Discussed in #769

Originally posted by capellavacancies April 17, 2024
I've read online WebP it's supported (source) but when I try to open a WebP file it says it's not supported. Ideas ?

@cameronwhite cameronwhite added this to the 2.1.2 milestone Apr 17, 2024
cameronwhite added a commit that referenced this issue Apr 17, 2024
This should cause the webp pixbuf loader to be packaged up into the
macOS installer.

Bug: #770
@badcel
Copy link
Contributor

badcel commented Apr 18, 2024

It probably is related to this issue?

https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/issues/103

@cameronwhite
Copy link
Member Author

Yeah, the webp-pixbuf-loader does work to add webP support to Pinta, so it's just matter of packaging it.

I had gotten it packaged properly for macOS, but seem to have not actually merged that in properly

cameronwhite added a commit that referenced this issue Apr 20, 2024
This was previously done in the feature/webp-bundle branch which was never merged.

- Install webp-pixbuf-loader on the macOS builds.
- Fix the bundle_gtk script to better handle the webp libraries
  - When parsing the otool output, recognize @rpath/libfoo.dylib and ensure that these libraries are also bundled
  - Include these in install_name_tool to properly update references when symlinks are involved

Fixes: #770

(cherry picked from commit 5ed7b3c)
(cherry picked from commit cde0992)
(cherry picked from commit 8dcaea2)
(cherry picked from commit ad2bbba)
(cherry picked from commit 501d84e)
(cherry picked from commit 4e18125)
@cameronwhite
Copy link
Member Author

This has been backported to the 2.1 branch and will be in the next minor release

@BolteDev
Copy link

This also isn't working in Windows on 2.1.2

@cameronwhite
Copy link
Member Author

with b930be3 the webp pixbuf loader is packaged with the Windows installer too. You can try out the latest build from https://github.com/PintaProject/Pinta/actions/runs/9056221969 (requires Github login)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants