New error message when opening unsupported formats #143
Conversation
| string markup = "<span weight=\"bold\" size=\"larger\">{0}</span>\n\n{1}"; | ||
|
|
||
| string secondaryText = string.Format(Catalog.GetString("Could not open file: {0}"), filename); | ||
| secondaryText += $"{Environment.NewLine}{Environment.NewLine}Pinta supports the following file formats:{Environment.NewLine}"; |
There was a problem hiding this comment.
The "Pinta supports ..." string also needs to be translatable like the line above (i.e. using Catalog.GetString()).
https://github.com/PintaProject/Pinta/wiki/Translations has more details on how translations work
There was a problem hiding this comment.
Ok, I'll change it.
| string secondaryText = string.Format(Catalog.GetString("Could not open file: {0}"), filename); | ||
| secondaryText += $"{Environment.NewLine}{Environment.NewLine}Pinta supports the following file formats:{Environment.NewLine}"; | ||
| var extensions = from format in PintaCore.System.ImageFormats.Formats | ||
| from extension in format.Extensions |
There was a problem hiding this comment.
Maybe this should also check whether an exporter exists for the format? I'm not sure if there are any write-only formats, though.
There was a problem hiding this comment.
I checked available formats for existing of exporter and found that around the half of the formats are available only for import. So I see two possible solutions:
- Show formats only available in both ways (Import/Export).
- Show import and export formats separately. More sophisticated way for a user, I'm not sure is it worth it.
I like simple way more, though.
For now, I changed LINQ with additional where statement:
where format.Exporter != null
But can change it without any problem.
There was a problem hiding this comment.
Thanks! Should it be the other way around, though? (checking format.Importer != null) since this error is show when a file fails to import.
Pinta.Core/Pinta.Core.csproj
Outdated
| @@ -54,8 +54,8 @@ | |||
| <Reference Include="System.Core" /> | |||
| <Reference Include="System.Data" /> | |||
| <Reference Include="System.Xml" /> | |||
| <Reference Include="WindowsBase" /> | |||
There was a problem hiding this comment.
Is this being used for anything?
There was a problem hiding this comment.
My bad. It's useless.
|
Looks good, thank you! |
Report bug window is not useful for the users when they open files with unsupported formats, so I wrote another type of dialog window. Changes made based on info from tickets #1856821 and duplicate #1432606.