Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pinta.Resources] Use symbolic tool icons. #204

Merged
merged 1 commit into from
Jan 8, 2022

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Jan 7, 2022

Pinta's original icons don't work as well anymore in the era of dark themes and HiDPI screens.

Transitioning to symbolic SVG icons allow them to be displayed better at higher resolutions, and to be automatically colored to be viewable on dark themes. This updates the icons for Pinta's toolbox.

toolbox

Unfortunately we don't have a contributing artist, so it's a combination of icons scavenged from appropriately licensed resources and programmer art!

Copy link
Member

@cameronwhite cameronwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The new icons look pretty good to me
There were a few bugs on launchpad about this, so it's great to see this being worked on 👍

I'm planning to do a 2.0.1 release imminently for some of the regressions that have been fixed, so I'll wait until after to merge this

Pinta.Resources/Pinta.Resources.csproj Show resolved Hide resolved
@cameronwhite cameronwhite merged commit e0f12a8 into PintaProject:master Jan 8, 2022
@jpobst jpobst deleted the symbolic-icons branch January 12, 2022 03:09
@lobre
Copy link

lobre commented Feb 4, 2022

Hi, not sure if my problem is related to this PR, but commenting just in case.

I am running Pinta 2.0.2 installed with nixpkgs on Ubuntu 20.04. When I open it, I receive this exception.

Icon 'tool-move' not present in theme Adwaita

GLib.GException: Icon 'tool-move' not present in theme Adwaita
   at Gtk.IconTheme.LoadIcon(String icon_name, Int32 size, IconLookupFlags flags)
   at Pinta.Core.GtkExtensions.LoadIcon(IconTheme theme, String icon_name, Int32 size) in /build/source/Pinta.Core/Extensions/GtkExtensions.cs:line 181
   at Pinta.Tools.MoveSelectedTool.get_DefaultCursor() in /build/source/Pinta.Tools/Tools/MoveSelectedTool.cs:line 47
   at Pinta.Core.BaseTool..ctor(IServiceManager services) in /build/source/Pinta.Core/Classes/BaseTool.cs:line 58
   at Pinta.Tools.BaseTransformTool..ctor(IServiceManager services) in /build/source/Pinta.Tools/Tools/BaseTransformTool.cs:line 47
   at Pinta.Tools.MoveSelectedTool..ctor(IServiceManager services) in /build/source/Pinta.Tools/Tools/MoveSelectedTool.cs:line 39
   at Pinta.Tools.CoreToolsExtension.Initialize() in /build/source/Pinta.Tools/CoreToolsExtension.cs:line 52
   at Pinta.MainWindow.OnActivated() in /build/source/Pinta/MainWindow.cs:line 103
   at GLib.Application.Activated_cb(IntPtr inst)

This happens whatever the GTK theme.
Could this be related to the switch to SVG icons?

Thanks

@cameronwhite
Copy link
Member

It should be unrelated since this PR wasn't in the 2.0.2 release
That sounds like a packaging or path issue , where it can't find Pinta's custom icons that are installed under <prefix>/share/icons/hicolor/...

@lobre
Copy link

lobre commented Feb 6, 2022

Thanks for the hint @cameronwhite and sorry for the noise then.

@Imerion
Copy link

Imerion commented Jan 24, 2023

Could there perhaps be an option for choosing the old icons instead? I prefer the high-colored look and I feel it is easier to quickly find the correct one with a bit of color. If not, perhaps they could be made available as a plugin.

@N0rdmann
Copy link

+1 on Imerion's request
I regularly switch between paint.net and Pinta and would love to have back matching icons 🥰
would be nice if this can be somehow archived without recompiling etc.

@cameronwhite
Copy link
Member

Pull requests are welcome for this - I'm mainly focused on the GTK4 port currently
It perhaps could be solved with changing the icon theme, but I'm not sure if it works to override symbolic icons with normal coloured icons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants