Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select tool not selcting corner canvas pixels #223

Merged
merged 10 commits into from
May 25, 2022

Conversation

Zekiah-A
Copy link
Contributor

@Zekiah-A Zekiah-A commented May 24, 2022

Fixed the select tool as previously you were unable to drag select the last row of pixels on the X and Y axis

Screenshot_20220524_013912
Before: Unable to select the very edge pixels ^

Screenshot_20220524_015009
After: Now selects canvas edge pixel on x and y when mouse is dragged all the way to the edge

@Zekiah-A
Copy link
Contributor Author

Also I am unsure why github displays so many commits for this PR, changes can be seen at "Files Changed"

@cameronwhite
Copy link
Member

Good catch, thanks! I think there's also a similar issue in the mouse down handler, if you initially click below or to the right of the canvas

@Zekiah-A
Copy link
Contributor Author

image
We may need to offset the dotted line border for the rectangle of the selection by -1px on the X and Y, as even though selection is now technically correct, because it is on the very edge of the image the dotted line there is hard to see

@cameronwhite
Copy link
Member

Good point - I see in DocumentSelection.Draw() that it's being offset slightly, which is probably why the left / top is easy to see

@Zekiah-A
Copy link
Contributor Author

Zekiah-A commented May 25, 2022

image

Okay this is epic 😎 everything works now, pinta is now better than photoshop, affinity, paint.net and maybe even MS paint

@cameronwhite
Copy link
Member

Nice, looks good to me with that 0.5 translation removed

@cameronwhite cameronwhite merged commit 21caee2 into PintaProject:master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants