-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix select tool not selcting corner canvas pixels #223
Conversation
Also I am unsure why github displays so many commits for this PR, changes can be seen at "Files Changed" |
Good catch, thanks! I think there's also a similar issue in the mouse down handler, if you initially click below or to the right of the canvas |
Good point - I see in |
Nice, looks good to me with that 0.5 translation removed |
Fixed the select tool as previously you were unable to drag select the last row of pixels on the X and Y axis
Before: Unable to select the very edge pixels ^
After: Now selects canvas edge pixel on x and y when mouse is dragged all the way to the edge