-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some review based on reading the bubblejail script #2
Comments
`man bwrap` > Create a new terminal session for the sandbox (calls setsid()). https://www.openwall.com/lists/oss-security/2017/06/03/9 ncopa/su-exec#23 tianon/gosu#37 https://ruderich.org/simon/notes/su-sudo-from-root-tty-hijacking Relates-to: #2
thank you for your feedback. waylandyou are right, as per https://gitlab.freedesktop.org/wayland/wayland/-/blob/a782152de0f0/src/wayland-client.c#L1217 Pulseaudio requires /etc/machine-idi'm pretty sure it works as is, see --as-pid-1i didn't run into trouble yet and remember quite the opposite. but my memory is vague here... share a deviceyou can do this today by appending the bwrap args right after bubblejail args
new-sessionyou are right, thanks. see ed062f6 seccompi'll glady accept patches ;-) |
Pulseaudio requires /etc/machine-idMaybe PA behaves differently in Void Linux or PA changed in newer versions. At least older versions of pulseaudio (!= piprewire-pulse) in Debian/Ubuntu/Fedora/Arch/... required it. seccompDumping some links of other implementations FTR
|
--as-pid-1Good summary: https://vagga.readthedocs.io/en/latest/pid1mode.html |
bubblejail/bubblejail
Line 189 in 82869d3
In theory
WAYLAND_DISPLAY
can contain an absolute path, though it's very uncommon.Pulseaudio requires
/etc/machine-id
.bubblejail/bubblejail
Line 268 in 82869d3
This can cause trouble with some programs and I see no good reason why it should be the default. Is there any reason why you added it as default.
There is no way to share a device (say
/dev/video0
). Exposing bwrap's--dev-bind[-try]
would be helpful.bubblejail/bubblejail
Lines 262 to 264 in 82869d3
Those flags can be replaced by
--dir
because/
is already antmpfs
.--new-session
is important unless you have an replacement in form of an seccomp filter.seccomp is important! even if it is complicated.
The text was updated successfully, but these errors were encountered: