Improve EnvelopeEditor UX by inserting and removing points on Press rather than Release #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis is failing on a pre-existing, unrelated issue in nightly related to gfx-rs/gfx#1070. Seems to be building fine on stable and beta so going to merge. |
|
this is beautiful. thank you. |
mitchmindtree
added a commit
to mitchmindtree/conrod
that referenced
this pull request
Nov 28, 2016
Bumped the minor version in this case due to very slight breaking change in EnvelopeEditor that changes the behaviour of point insertion and removal slightly. See PistonDevelopers#882 for details. Includes the patch for supporting OpenGL ES 3.0+ via an alternative shader program in PistonDevelopers#885.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also closes #880 cc @Kingsquee