Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to modern gfx-rs, using PSOs #260

Merged
merged 1 commit into from
Mar 13, 2016
Merged

Upgrade to modern gfx-rs, using PSOs #260

merged 1 commit into from
Mar 13, 2016

Conversation

mattico
Copy link
Contributor

@mattico mattico commented Mar 6, 2016

I've just started working on this (again) so it's not nearly done. I'm mostly just putting this up so that I don't forget about it again :)

Is there a reason to not use tilde/caret requirements in Cargo.toml? Cargo.lock is checked in so you still need to explicitly cargo update for anything to change.

Closes #214

@bvssvni
Copy link
Member

bvssvni commented Mar 6, 2016

Cargo interpretates "0.8.0" as "^0.8.0".

@mattico
Copy link
Contributor Author

mattico commented Mar 6, 2016

Wow, I feel like I should have figured that out by now.

@mattico
Copy link
Contributor Author

mattico commented Mar 6, 2016

That's all for today. I think it's mostly complete, if not mostly correct. Black screen for now, but it builds and there's no crashes.

@mattico
Copy link
Contributor Author

mattico commented Mar 10, 2016

It works! \o/

Except for this one triangle...
hematite
and mouselook. I think something changed in camera_controllers?

@mattico
Copy link
Contributor Author

mattico commented Mar 10, 2016

Fixed the missing triangle. I think the mouse problem is because glutin_window doesn't implement MouseRelative/glutin has broken mouse grabbing. See:
PistonDevelopers/glutin_window#72
rust-windowing/glutin#696

Turns out I was right the first time. glutin_window doesn't implement MouseRelative. But after fixing that it still doesn't work, despite the events propagating correctly.

@mattico
Copy link
Contributor Author

mattico commented Mar 10, 2016

Also worth investigating: this version gets ~250fps while master gets ~500fps on my machine. Probably doing something wrong with the vbuffer or with encoder.reset()

@toqueteos
Copy link
Contributor

Congrats @mattico! You are doing awesome work here 👍

@mattico mattico changed the title [WIP] Upgrade for modern gfx-rs, using PSOs [WIP] Upgrade to modern gfx-rs, using PSOs Mar 12, 2016
@mattico mattico changed the title [WIP] Upgrade to modern gfx-rs, using PSOs Upgrade to modern gfx-rs, using PSOs Mar 12, 2016
@mattico
Copy link
Contributor Author

mattico commented Mar 12, 2016

Alright, everything works now. Performance also seems to be better with the sdl2 window. I'll squash these commits before merging.

The changes seem pretty straightforward, but I'd like at least one other opinion before I pull the trigger.

@bvssvni
Copy link
Member

bvssvni commented Mar 12, 2016

Looks good!

mattico added a commit that referenced this pull request Mar 13, 2016
Upgrade to modern gfx-rs, using PSOs
@mattico mattico merged commit 866d3a1 into PistonDevelopers:master Mar 13, 2016
@mattico
Copy link
Contributor Author

mattico commented Mar 13, 2016

Of course I remember this right after I hit the merge button...

Since we're still using SDL, I shouldn't remove the part of the README that has SDL stuff in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants