-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to modern gfx-rs, using PSOs #260
Conversation
Cargo interpretates "0.8.0" as "^0.8.0". |
Wow, I feel like I should have figured that out by now. |
That's all for today. I think it's mostly complete, if not mostly correct. Black screen for now, but it builds and there's no crashes. |
Fixed the missing triangle. Turns out I was right the first time. glutin_window doesn't implement MouseRelative. But after fixing that it still doesn't work, despite the events propagating correctly. |
Also worth investigating: this version gets ~250fps while master gets ~500fps on my machine. Probably doing something wrong with the vbuffer or with encoder.reset() |
Congrats @mattico! You are doing awesome work here 👍 |
Alright, everything works now. Performance also seems to be better with the sdl2 window. I'll squash these commits before merging. The changes seem pretty straightforward, but I'd like at least one other opinion before I pull the trigger. |
Looks good! |
Upgrade to modern gfx-rs, using PSOs
Of course I remember this right after I hit the merge button... Since we're still using SDL, I shouldn't remove the part of the README that has SDL stuff in it. |
I've just started working on this (again) so it's not nearly done. I'm mostly just putting this up so that I don't forget about it again :)
Is there a reason to not use tilde/caret requirements in Cargo.toml? Cargo.lock is checked in so you still need to explicitlycargo update
for anything to change.Closes #214