adding rfc admin panel #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
701i
reviewed
Mar 3, 2022
RFCs/accepted/0000-admin-panel.md
Outdated
Comment on lines
14
to
19
| - For point one, we can design a table with 3 columns. | ||
| - First column have Admins | ||
| - Second for users | ||
| - Third for places | ||
| Every column will have its own searcher and filter. | ||
| Also, every column will have a button. That button depends on what the column is. For example. |
There was a problem hiding this comment.
Hi, Master partner I was checking your RFC and find some upgrades that You may do:
- Under the line 10, You could put a nested list about the design of the table to be more easy to read
Suggested change
| - For point one, we can design a table with 3 columns. | |
| - First column have Admins | |
| - Second for users | |
| - Third for places | |
| Every column will have its own searcher and filter. | |
| Also, every column will have a button. That button depends on what the column is. For example. | |
| + In order to organize the information of the users, admins and places. | |
| + For point one, we can design a table with 3 columns. | |
| + First column have Admins | |
| + Second for users | |
| + Third for places | |
| Every column will have its own searcher and filter. | |
| Also, every column will have a button. That button depends on what the column is. For example. |
- Or You may do a table to be more descriptive
Suggested change
| - For point one, we can design a table with 3 columns. | |
| - First column have Admins | |
| - Second for users | |
| - Third for places | |
| Every column will have its own searcher and filter. | |
| Also, every column will have a button. That button depends on what the column is. For example. | |
| **Admins** | **Users** | **Places** | |
| ------------- | ------------- | ------------- | |
| (example) | (example) | (example) |
RFCs/accepted/0000-admin-panel.md
Outdated
Comment on lines
21
to
24
| - Users: we click the button and we will have 3 choices: | ||
| - Edit user: this modal will allows you to edit the user | ||
| - Ban user: with this, you can ban user and send to him/her an email in order to explain why | ||
| delete user: you can send an email to the user explaining that her/him account will be deleted. |
There was a problem hiding this comment.
Another upgrades that You may do Its put a nested list about the users :
Suggested change
| - Users: we click the button and we will have 3 choices: | |
| - Edit user: this modal will allows you to edit the user | |
| - Ban user: with this, you can ban user and send to him/her an email in order to explain why | |
| delete user: you can send an email to the user explaining that her/him account will be deleted. | |
| + Users: we click the button and we will have 3 choices: | |
| + Edit user: this modal will allows you to edit the user | |
| + Ban user: with this, you can ban user and send to him/her an email in order to explain why | |
| + Delete user: you can send an email to the user explaining that her/him account will be deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.